Re: sysfs: spit a warning to users when they try to create aduplicate sysfs file

From: Cornelia Huck
Date: Fri Sep 14 2007 - 08:06:32 EST


On Thu, 13 Sep 2007 16:41:18 -0700,
Greg KH <greg@xxxxxxxxx> wrote:


> int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
> {
> - if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
> + if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
> + printk(KERN_WARNING, "sysfs: duplicate filename '%s' "

Stray ',' here ------------------->^
> + "can not be created\n", sd->s_name);
> + WARN_ON(1);
> return -EEXIST;
> + }
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/