Re: rtc-ds1742.c should use resource_size_t for base address

From: Atsushi Nemoto
Date: Fri Sep 14 2007 - 12:45:06 EST


On Fri, 14 Sep 2007 15:54:27 +1000, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Currently the rtc driver, rtc-ds1742.c uses an unsigned long to store
> the base mmio address of the NVRAM/RTC. This breaks on systems like
> PowerPC 440, which is a 32-bit core with 36-bit physical addresses: IO
> on the system, including the RTC, is typically above the 4GB point,
> and cannot fit into an unsigned long.
>
> This patch fixes the problem by replacing the unsigned long with a
> resource_size_t. Tested on Ebony (PPC440) (with additional patches to
> instantiate the ds1742 platform device appropriately).
>
> Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>

Thanks!

Acked-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/