Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr inskb to reply packet

[YOSHIFUJI Hideaki / 吉藤英明]

In article <20070917.192044.48396034.davem@xxxxxxxxxxxxx> (at Mon, 17 Sep 2007 19:20:44 -0700 (PDT)), David Miller <davem@xxxxxxxxxxxxx> says:

> From: lepton <ytht.net@xxxxxxxxx>
> Date: Tue, 18 Sep 2007 10:16:17 +0800
> 
> > Hi,
> >   In some situation, icmp_reply and ip_send_reply will send
> >   out packet with the wrong source addr, the following patch
> >   will fix this.
> > 
> >   I don't understand why we must use rt->rt_src in the current
> >   code, if this is a wrong fix, please correct me.
> > 
> > Signed-off-by: Lepton Wu <ytht.net@xxxxxxxxx>
> 
> That the address is wrong is your opinion only :-)
> 
> Source address selection is a rather complex topic, and
> here we are definitely purposefully using the source
> address selected by the routing lookup for the reply.

And, if you do think something is "wrong", you need to describe it
in detail, at least.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/