Re: [PATCH] Clarify pci_iomap() usage for MMIO-only devices

From: Alan Cox
Date: Tue Sep 18 2007 - 06:27:26 EST


On Mon, 17 Sep 2007 16:22:07 -0400
"Luis R. Rodriguez" <mcgrof@xxxxxxxxx> wrote:

> This patch updates the pci_iomap() kernel-doc to make it clarify the
> case when read*()/write*() can be called over ioread*/iowrite*(). When
> driver writers read this documenation sometimes it is assumed you just
> *need* to use ioread*()/iorwrite*(). We have an exception so lets just
> clarify this is not true for the exception.
>
> lib/iomap.c | 11 ++++++++---
> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxx>

Reviewed-by: Alan Cox <alan@xxxxxxxxxx>

Although I would say s/recommended/required/

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/