Re: [PATCH] Combine instrumentation menus inkernel/Kconfig.instrumentation

[Randy Dunlap]

On Mon, 17 Sep 2007 14:45:52 -0400 Mathieu Desnoyers wrote:

> Combine instrumentation menus in kernel/Kconfig.instrumentation

Thanks, looks very good.

> Quoting Randy:
> 
> "It seems sad that this patch sources Kconfig.marker, a 7-line file,
> 20-something times.  Yes, you (we) don't want to put those 7 lines
> into 20-something different files, so sourcing is the right thing.
> 
> However, what you did for avr32 seems more on the right track to me:
> make _one_ Instrumentation support menu that includes PROFILING,
> OPROFILE, KPROBES, and MARKERS and then use (source) that in all
> of the arches."
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
> CC: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Reviewed-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
or
Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

> ---
>  arch/alpha/Kconfig             |    2 -
>  arch/alpha/oprofile/Kconfig    |   23 ----------------------
>  arch/arm/Kconfig               |    2 -
>  arch/arm/oprofile/Kconfig      |   42 -----------------------------------------
>  arch/blackfin/Kconfig          |    2 -
>  arch/blackfin/oprofile/Kconfig |   29 ----------------------------
>  arch/cris/Kconfig              |    2 +
>  arch/frv/Kconfig               |    2 +
>  arch/h8300/Kconfig             |    2 +
>  arch/i386/Kconfig              |   25 ------------------------
>  arch/i386/oprofile/Kconfig     |   17 ----------------
>  arch/ia64/Kconfig              |   15 --------------
>  arch/ia64/oprofile/Kconfig     |   20 -------------------
>  arch/m32r/Kconfig              |    2 -
>  arch/m32r/oprofile/Kconfig     |   23 ----------------------
>  arch/m68k/Kconfig              |    2 +
>  arch/m68knommu/Kconfig         |    2 +
>  arch/mips/Kconfig              |    2 -
>  arch/mips/oprofile/Kconfig     |   23 ----------------------
>  arch/parisc/Kconfig            |    2 -
>  arch/parisc/oprofile/Kconfig   |   23 ----------------------
>  arch/powerpc/Kconfig           |   15 --------------
>  arch/powerpc/oprofile/Kconfig  |   24 -----------------------
>  arch/ppc/Kconfig               |    2 -
>  arch/s390/Kconfig              |   16 ---------------
>  arch/s390/oprofile/Kconfig     |   22 ---------------------
>  arch/sh/Kconfig                |    2 -
>  arch/sh/oprofile/Kconfig       |   23 ----------------------
>  arch/sh64/Kconfig              |    2 -
>  arch/sh64/oprofile/Kconfig     |   23 ----------------------
>  arch/sparc/Kconfig             |    6 -----
>  arch/sparc/oprofile/Kconfig    |   17 ----------------
>  arch/sparc64/Kconfig           |   15 --------------
>  arch/sparc64/oprofile/Kconfig  |   17 ----------------
>  arch/um/Kconfig                |    2 +
>  arch/v850/Kconfig              |    2 +
>  arch/x86_64/Kconfig            |   15 --------------
>  arch/x86_64/oprofile/Kconfig   |   17 ----------------
>  arch/xtensa/Kconfig            |    2 +
>  kernel/Kconfig.instrumentation |   40 +++++++++++++++++++++++++++++++++++++++
>  40 files changed, 72 insertions(+), 452 deletions(-)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/