Re: [PATCH] usb-gadget-ether: Prevent oops caused by errorinterrupt race -V2 (comments update)

From: Thomas Gleixner
Date: Sat Sep 22 2007 - 19:32:55 EST


On Sat, 2007-09-22 at 13:53 -0700, David Brownell wrote:
> > Sigh. I need a real deep look inside that code to understand, why
> > tx_reqs is not a requestlist but a freelist. Very intuitive naming :)
>
> It *is* a list of requests: free ones -- the only kind this level of
> driver is allowed to remember! ;)
>
> Yeah, I had to go back and read the driver again before I understood
> just what problem this patch was trying to fix. Which is why I wanted
> to make sure the mismatch between comments and contents was resolved.

Fair enough. Thanks for sanitizing the comments.

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/