Re: [Patch 2/2] Relay reset consumend

From: Christoph Hellwig
Date: Sun Sep 23 2007 - 08:46:18 EST


On Tue, Sep 18, 2007 at 09:46:59PM -0700, David J. Wilder wrote:
> This patch allows relay channels to be reset i.e. unconsumed.
> Basically allows a 'rewind' function for flight-recorder tracing.

This should be patch 1 because relay_reset_consumed is used by
the other patch.

> +/**
> + * __relay_reset_consumed - reset a channel buffer's consumed count
> + * @buf: the channel buffer
> + *
> + * See relay_reset_consumed for description of effect.
> + */
> +static inline void __relay_reset_consumed(struct rchan_buf *buf)

Please don't mark functions explicitly inline unless needed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/