Re: [PATCH 3/3] cxacru: Cleanup code by removing "ret = ret;" assignments

From: Simon Arlott
Date: Sun Sep 23 2007 - 11:36:20 EST


Cleanup code by removing "ret = ret;" assignments.

Signed-Off-By: Simon Arlott <simon@xxxxxxxxxxx>
---
drivers/usb/atm/cxacru.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 35308a8..bb3169c 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -496,7 +496,6 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
if (ret < 0) {
usb_err(instance->usbatm, "submit of read urb for cm %#x failed (%d)\n",
cm, ret);
- ret = ret;
goto fail;
}

@@ -514,21 +513,18 @@ static int cxacru_cm(struct cxacru_data *instance, enum cxacru_cm_request cm,
if (ret < 0) {
usb_err(instance->usbatm, "submit of write urb for cm %#x failed (%d)\n",
cm, ret);
- ret = ret;
goto fail;
}

ret = cxacru_start_wait_urb(instance->snd_urb, &instance->snd_done, NULL);
if (ret < 0) {
usb_err(instance->usbatm, "send of cm %#x failed (%d)\n", cm, ret);
- ret = ret;
goto fail;
}

ret = cxacru_start_wait_urb(instance->rcv_urb, &instance->rcv_done, &actlen);
if (ret < 0) {
usb_err(instance->usbatm, "receive of cm %#x failed (%d)\n", cm, ret);
- ret = ret;
goto fail;
}
if (actlen % CMD_PACKET_SIZE || !actlen) {
--
1.5.0.1

--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/