Re: 2.6.23-rc6-mm1

From: Mel Gorman
Date: Mon Sep 24 2007 - 07:15:13 EST


On (22/09/07 14:11), Satyam Sharma didst pronounce:
>
> > -static volatile int kgdb_hwbreak_sstep[NR_CPUS];
> > +volatile int kgdb_hwbreak_sstep[NR_CPUS];
>
> That looks fishy to me. Why is it volatile-qualified?

It turned out that it was unnecessary. A follow-up patch removed the volatile
and kept the static.

> And does that
> actually want to be a per-cpu var?
>

--
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/