Re: 2.6.23-rc8-mm1 - drivers/net/ibm_newemac/mal - broken

From: Andrew Morton
Date: Tue Sep 25 2007 - 12:16:54 EST


On Tue, 25 Sep 2007 18:23:58 +0530 Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> wrote:

> Hi Andrew,
>
> The drivers/net/ibm_newemac/mal seems to be broken, which stop with
> build error

(please cc netdev@xxxxxxxxxxxxxxx on networking things)

> CC drivers/net/ibm_newemac/mal.o
> drivers/net/ibm_newemac/mal.c: In function âmal_schedule_pollâ:
> drivers/net/ibm_newemac/mal.c:238: error: too few arguments to function ânetif_rx_schedule_prepâ
> drivers/net/ibm_newemac/mal.c:238: error: too few arguments to function ânetif_rx_schedule_prepâ
> drivers/net/ibm_newemac/mal.c:238: error: too few arguments to function ânetif_rx_schedule_prepâ
> drivers/net/ibm_newemac/mal.c:241: error: too few arguments to function â__netif_rx_scheduleâ
> drivers/net/ibm_newemac/mal.c: In function âmal_poll_disableâ:
> drivers/net/ibm_newemac/mal.c:321: error: â__LINK_STATE_RX_SCHEDâ undeclared (first use in this function)
> drivers/net/ibm_newemac/mal.c:321: error: (Each undeclared identifier is reported only once
> drivers/net/ibm_newemac/mal.c:321: error: for each function it appears in.)
> drivers/net/ibm_newemac/mal.c: In function âmal_pollâ:
> drivers/net/ibm_newemac/mal.c:337: error: âstruct net_deviceâ has no member named âquotaâ
> drivers/net/ibm_newemac/mal.c:337: warning: type defaults to âintâ in declaration of â_xâ
> drivers/net/ibm_newemac/mal.c:337: error: âstruct net_deviceâ has no member named âquotaâ
> drivers/net/ibm_newemac/mal.c:375: error: too few arguments to function â__netif_rx_completeâ
> drivers/net/ibm_newemac/mal.c:390: warning: passing argument 2 of ânetif_rx_rescheduleâ makes pointer from integer without a cast
> drivers/net/ibm_newemac/mal.c:404: error: âstruct net_deviceâ has no member named âquotaâ
> drivers/net/ibm_newemac/mal.c: In function âmal_probeâ:
> drivers/net/ibm_newemac/mal.c:542: error: âstruct net_deviceâ has no member named âweightâ
> drivers/net/ibm_newemac/mal.c:543: error: âstruct net_deviceâ has no member named âpollâ
> drivers/net/ibm_newemac/mal.c: In function âmal_removeâ:
> drivers/net/ibm_newemac/mal.c:660: error: implicit declaration of function ânetif_poll_disableâ
> make[3]: *** [drivers/net/ibm_newemac/mal.o] Error 1
> make[2]: *** [drivers/net/ibm_newemac] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2

Yes, there's been a lot of breakage in netdev land:

git-net-fix-macec.patch
git-net-sky2-fixups.patch
git-net-fix-wireless-kconfig.patch
git-net-fix-spidernet-build.patch
git-net-sctp-build-fix.patch
spider_net_ethtool-keep-up-with-recent-netdev-stats-changes.patch
pasemi_mac-build-fix-after-recent-netdev-stats.patch
git-net-fix-pasemi_mac.patch
make-mv643xx_ethc-build-again.patch

but we're getting there. It looks like ibmn_newemac is more busted than
most...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/