Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

[roel]

Erez Zadok wrote:

> @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist)
>  
>  	BUG_ON(!S_ISDIR(dentry->d_inode->i_mode));
>  
> -	if ((err = unionfs_partial_lookup(dentry)))
> +	if (unlikely((err = unionfs_partial_lookup(dentry))))
>  		goto out;
>  
>  	bstart = dbstart(dentry);

Is it bad to leave this assignment within the unlikely()?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/