Re: [PATCH] fs: Correct SuS compliance for open of large filewithout options

From: Jens Axboe
Date: Thu Sep 27 2007 - 10:34:32 EST


On Thu, Sep 27 2007, Alan Cox wrote:
> On Thu, 27 Sep 2007 07:01:18 -0700
> Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
>
> > On Thu, 27 Sep 2007 14:29:19 +0100
> > Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > The early LFS work that Linux uses favours EFBIG in various places.
> > > SuSv3 specifically uses EOVERFLOW for this as noted by Michael (Bug
> > > 7253)
> > isn't this an ABI change?
>
> Its a change of a specific error return from the wrong error to the right
> one, nothing more. Fixing the returned error gives us correct behaviour
> according to the standards and other systems.

It may still break applications. Waving some standard at them if they
complain is unlikely to impress them.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/