Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

[Jeff Garzik]

Alan Cox wrote:
> > Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation,
> > rather than just getting stuck there forever.
>
> Why 512 words ?

Though I have queued Mark's patch to be applied, my gut feeling would 
lean towards a single DRQ block, rather than 512.


> >  	ata_altstatus(ap);
> > -	ata_chk_status(ap);
> > +	ata_drain_fifo(ap, qc);
>
> ap->ops->cleanup();
>
> might be wiser

If someone needs that, they can override the error handler with their 
own.  No need for a new op.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/