Re: [REGRESSION from 2.6.23-rc8] (was: Re: 2.6.23-rc4-mm1 and -rc6-mm1: boot failure on HP nx6325, related to clockevents)

From: Andi Kleen
Date: Sun Sep 30 2007 - 05:58:46 EST



>
> PIT keeps jiffies (and the system) running, but the local APIC timer
> interrupts can get out of sync due to this C1E effect.

The way C1e works on AMD is that even when one core is woken up
by the PIT the APIC timer resumes on the other core on the socket too because
the deep power saving that breaks the APIC timer is only active
with both cores idle.

And on true multi socket systems there is currently no such deep
C1e -- apic timer should always work.

At least that is how it was supposed to work and while I admit
I haven't read every mail in this endless thread closely I didn't
think Rafael's box contradicted that.

> I don't think this is a critical problem, but it is wrong nevertheless.
>
> I think it's safe to revert the C1E patch

Yes the C1e patch is completely redundant on a non clockevents kernel.

> and postpone the fix to the
> clock events conversion.

Well, a change is only needed together with clockevent's "apicrunsmaintimer"
default; but not on any non clockevents kernel.


-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/