On (02/10/07 14:15), Ingo Molnar didst pronounce:And if it isn't set? I can easily see building a new kernel with stats off and forgetting to change the boot options.* Mel Gorman <mel@xxxxxxxxx> wrote:
Dirt. Booting with "profile=sleep,2" is broken in 2.6.23-rc9 and 2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a discussion in another thread and noticed it broken in -mm as well (2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the prime candidates are welcome or preferably, pointing out that I'm an idiot because I missed twiddling some config change.Mel, does the patch below fix this bug for you? (Note: you will need to enable CONFIG_SCHEDSTATS=y too.)
Nice one Ingo - got it first try. The problem commit was
dd41f596cda0d7d6e4a8b139ffdfabcefdd46528 and it's clear that the code removed
in this commit is put back by this latest patch. When applied, profile=sleep
works as long as CONFIG_SCHEDSTAT is set.