Re: [RFC/RFT] kbuild: save ARCH & CROSS_COMPILE

From: Andi Kleen
Date: Tue Oct 09 2007 - 07:08:57 EST


On Tue, Oct 09, 2007 at 12:00:30PM +0200, Sam Ravnborg wrote:
> On Tue, Oct 09, 2007 at 11:39:21AM +0200, Andi Kleen wrote:
> > Sam Ravnborg <sam@xxxxxxxxxxxx> writes:
> > >
> > > -ARCH ?= $(SUBARCH)
> > > -CROSS_COMPILE ?=
> >
> > Can you do this in a way that there are still these ARCH/CROSS_COMPILE
> > lines that are just overriden when empty or have their default value?
> >
> > This way defaults could be still patched in for special cases.
>
> If it is OK to drop the $(SUBARCH) assingment like this then yes.
> ARCH ?=
> CROSS_COMPILE ?=

As long as both UML and normal architectures work still out of the
box yes

> I was wondering why we had the empty CROSS_COMPILE assigment and this
> explains why.
> But why patch something in here in the fisrt place?
> It seems to be a workaround for the actual issue this patch addresses - no?

Mostly.

The difference is that Kbuild.config would likely contain other stuff
too that might be not fit into a patch? Ok it's not a big difference.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/