Re: [PATCH -mm] slub: fix cpu hotplug offline/online path

From: Christoph Lameter
Date: Tue Oct 09 2007 - 15:16:14 EST


On Tue, 9 Oct 2007, Pekka Enberg wrote:

> Hi Christoph,
>
> On 10/9/07, Christoph Lameter <clameter@xxxxxxx> wrote:
> > Our system come by default with the possibility of 1k cpus. However, a
> > small system may only have 8 cpus.
>
> Maybe I am reading the code wrong, but I don't why that matters as
> it's all statically allocated anyway (the per-cpu kmem_cache_cpu
> array). In any case, I certainly don't object to your proposal, just
> can't figure out why it matters.

The kmem_cache_cpu structures are allocated using DEFINE_PER_CPU.

The per cpu areas should be dynamically allocated as necessary. There is
work in progress by Mike Travis to do that. You are right in that (on
x86_64 at least) we define a static array for all processors.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/