Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

[Valdis . Kletnieks]

On Wed, 10 Oct 2007 08:40:31 PDT, Randy Dunlap said:

> >>>  config SECURITY_SELINUX
> >>>  	bool "NSA SELinux Support"
> >>> -	depends on SECURITY_NETWORK && AUDIT && NET && INET
> >>> +	depends on SECURITY
> >>> +	select SECURITY_NETWORK
> >>> +	select AUDIT
> >>> +	select NET
> >>> +	select INET
> >>>  	select NETWORK_SECMARK

> AUDIT isn't quite library code, still I don't have a (big) problem with
> selecting it or NETWORK_SECMARK.  (other than select is evil :)
> 
> OTOH, NET and INET are large config options, not library-like code, and
> should not be selected.

If it does a 'select SECURITY_NETWORK' but NET=n, does the resulting kernel
actually build?  The problem seems to be that select isn't transitive - if
you select something, it won't automagically select that something's pre-reqs
(modulo the recent patches I've seen posted, have those been mainlined?).

Attachment: pgp00000.pgp
Description: PGP signature