Re: [PATCH] ibmpex: Release IPMI user if hwmon registration fails

[Mark M. Hoffman]

Hi:

* Darrick J. Wong <djwong@xxxxxxxxxx> [2007-10-09 15:08:24 -0700]:
> Roel Kluin <12o3l@xxxxxxxxxx> found a minor defect in the init code if
> hwmon device registration fails.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> 
>  drivers/hwmon/ibmpex.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index fe2c261..c462824 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -498,8 +498,7 @@ static void ibmpex_register_bmc(int iface, struct device *dev)
>  		printk(KERN_ERR DRVNAME ": Error, unable to register hwmon "
>  		       "class device for interface %d\n",
>  		       data->interface);
> -		kfree(data);
> -		return;
> +		goto out_user;
>  	}
>  
>  	/* finally add the new bmc data to the bmc data list */

Applied to hwmon-2.6.git/testing, thanks.

-- 
Mark M. Hoffman
mhoffman@xxxxxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/