Re: [PATCH v2 2/2] X86: Introduce and enable PCI domain support

From: Greg KH
Date: Thu Oct 11 2007 - 17:53:59 EST


On Thu, Oct 11, 2007 at 04:58:30PM -0400, Jeff Garzik wrote:
>
> * fix bug in pci_read() and pci_write() which prevented PCI domain
> support from working (hardcoded domain 0).
>
> * unconditionally enable CONFIG_PCI_DOMAINS
>
> * implement pci_domain_nr() and pci_proc_domain(), as required of
> all arches when CONFIG_PCI_DOMAINS is enabled.
>
> * store domain in struct pci_sysdata, as assigned by ACPI
>
> * support "pci=nodomains"
>
> Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
> ---
> Revised per Andi's comments, and split into two patches.

Ugh:
In file included from include/linux/pci.h:785,
from drivers/pci/access.c:2:
include/asm/pci.h:16: error: redefinition of 'pci_domain_nr'
include/linux/pci.h:692: error: previous definition of 'pci_domain_nr' was here
include/asm/pci.h:22: error: redefinition of 'pci_proc_domain'
include/linux/pci.h:694: error: previous definition of 'pci_proc_domain' was here
make[1]: *** [drivers/pci/access.o] Error 1

I'll see if I can fix it up...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/