Re: [PATCH] remove GPL restriction from set_dumpable()

From: Christoph Hellwig
Date: Sun Oct 14 2007 - 17:04:01 EST


On Sun, Oct 14, 2007 at 01:04:31PM +0200, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@xxxxxxx>
>
> remove GPL restriction from set_dumpable()
>
> Commit 6c5d5238 introduced a set_dumpable() function that replaced the
> direct access to mm_struct->dumpable. I don't think there is any reason to
> restrict this function to EXPORT_SYMBOL_GPL() -- previously any module
> could modify current->mm->dumpable without any resitrictions, so it makes
> a little sense to turn this into 'internal interface' at once.
>
> There in fact are 3rd party modules that modify the dumpable flag, and
> this patch should fix the situation for them once again (for example
> vmware).

Nack, the just shouldn't do such things at all. I start to get really
sick of patches adding random exports everywhere.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/