Re: WARNING: at net/core/dev.c:2161 net_rx_action()

From: David Miller
Date: Mon Oct 15 2007 - 18:21:32 EST


From: Ingo Molnar <mingo@xxxxxxx>
Date: Tue, 16 Oct 2007 00:07:20 +0200

> looking at the dev.c code - can napi_struct->weight be zero
> legitimately? If yes then the 0 gets passed to the driver and the driver
> would return 1 - violating the assertion.

I touched upon this in another reply.

For forcedeth it should never be zero, it gets set in
netif_napi_add() to RX_WORK_PER_LOOP which is unconditionally
defined to 64.

Afterwards napi->weight should never be modified and that is
what is passed into n->poll().

Perhaps some memory scribble is causing it to be zero'd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/