Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kpageflagsinterfaces

From: Dave Hansen
Date: Mon Oct 15 2007 - 21:08:20 EST


On Mon, 2007-10-15 at 19:58 -0500, Matt Mackall wrote:
>
> > For the bits that we want to export, we could also add the unoptimized
> > access functions for any that don't already have them:
> >
> > #define __ClearPageReserved(page) __clear_bit(PG_reserved, &(page)->flags)
>
> Confused. Why are we interested in clear?

We're not. I just grabbed a random line to show the non-atomic
accessors. Any actual one we'd need to add would be:

#define __PageBuddy(page) __test_bit(PG_buddy, &(page)->flags)

It looks like we don't have any of these non-atomic ones for plain
__PageFoo(). So, we'd have to add them for each one that we wanted.
Still not much work, and still satisfies the "grep test". :)

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/