Re: [PATCH] Map volume and brightness events on thinkpads

From: Matthew Garrett
Date: Tue Oct 16 2007 - 15:20:38 EST


On Tue, Oct 16, 2007 at 12:14:32PM -0700, Linus Torvalds wrote:

> IOW, I think the thinkpad issue (and others like it) should be fixed by
> splitting up the KEY_VOLUMEUP "key" into separate KEY_VOLUMEUP and
> KEY_VOLUMEUP_NOTIFY key events, so that downstream user mode (and the
> kernel itself, for that matter) can know whether it's a informational
> message or whether it should be acted upon.

In principle I agree, but userspace already handles it. While it's
certainly more correct, I'm not sure it provides any other real
advantage.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/