wait_for_completion_interruptible() changes

From: Geert Uytterhoeven
Date: Thu Oct 18 2007 - 13:05:54 EST


Hi Andi, Ingo,

Recently the return value of wait_for_completion_interruptible() in case of
succesful completion has changed:
- in 2.6.23, it returns 0 on completion,
- in current linux-2.6.git, it returns -1 on completion.

I.e. this breaks all code that checks for a non-zero return value instead
of explicitly comparing with -ERESTARTSYS.

I suspect this is caused by the recent completion refactoring?

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village  Da Vincilaan 7-D1  B-1935 Zaventem  Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@xxxxxxxxxxx
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7  B-1840 Londerzeel  Belgium
VAT BE 0413.825.160 Â RPR Brussels
Fortis Bank Zaventem  Swift GEBABEBB08A  IBAN BE39001382358619