Re: [PATCH] reiserfs: don't drop PG_dirty when releasingsub-page-sized dirty file

From: Fengguang Wu
Date: Tue Oct 23 2007 - 10:40:33 EST


On Tue, Oct 23, 2007 at 10:10:53AM -0400, Chris Mason wrote:
> On Tue, 23 Oct 2007 19:56:20 +0800
> Fengguang Wu <wfg@xxxxxxxxxxxxxxxx> wrote:
>
> > On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote:
> > > [ adding reiserfs devs to the CC ]
> >
> > Thank you.
> >
> > This fix is kind of crude - even when it fixed Maxim's problem, and
> > survived my stress testing of a lot of patching and kernel compiling.
> > I'd be glad to see better solutions.
>
> This should be safe, reiserfs has the buffer heads themselves clean and
> the page should get cleaned eventually. The cancel_dirty_page call was
> just an optimization to be VM friendly.

> -chris

'chris' as in fs/reiserfs/{inode.c,namei.c}, and now in btrfs/*?

Nice to meet you ;-)

Fengguang

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/