Re: [patch] portman2x4.c: fix boot hang

[Frans Pop]

Ingo Molnar wrote:
>  if ((parport_read_status(p) & ESTB) == ESTB)
> -		return 1;	/* CODE 1 - Strobe Failure. */
> +		return -EIO;	/* CODE 1 - Strobe Failure. */
>  
>  /* Set for RXDATA0 where no damage will be done. */
>  /* 5 */
> @@ -475,7 +475,7 @@ static int portman_probe(struct parport
>  
>  /* 6 */
>  if ((parport_read_status(p) & ESTB) != ESTB)
> -		return 1;	/* CODE 1 - Strobe Failure. */
> +		return -EIO;	/* CODE 1 - Strobe Failure. */

Why are you keeping the "CODE 1" comment? Just "Strobe Failure" as comment 
would seem more consistent with the change.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/