Re: [PATCH 3/4] [x86] : Add support for the RDC R-321x SoC

[Andrew Morton]

On Tue, 16 Oct 2007 13:41:31 +0200
Florian Fainelli <florian.fainelli@xxxxxxxxxxxxx> wrote:

> +static struct {
> +	struct completion stop;
> +	volatile int running;
> +	struct timer_list timer;
> +	volatile int queue;
> +	int default_ticks;
> +	unsigned long inuse;
> +} rdc321x_wdt_device;

Why the volatiles?  If these actually help then it's probably an indication
that something is wrong in the implementation.

Documentation/volatile-considered-harmful.txt has some details.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/