Re: [PATCH] INPUT: fix hidinput_connect ignoring retval frominput_register_device

From: Jiri Kosina
Date: Mon Oct 29 2007 - 08:57:46 EST


On Mon, 29 Oct 2007, Dmitry Torokhov wrote:

> Please don't - the fix is completely broken for multi-input devices -
> if 2nd device fails to register we bail out of hidinput_connect and
> thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we
> never call hidinput_disconnect and who knows what will happen after
> that.

You are of course right, stupid me. I won't commit anything before first
morning coffee any more.

Thanks a lot.

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/