Re: [PATCH] Clean up scatterlist.h and introduce macros for readability.

From: Jens Axboe
Date: Mon Oct 29 2007 - 14:58:21 EST


On Mon, Oct 29 2007, Robert P. J. Day wrote:
>
> Add some macros to <linux/scatterlist.h> to make the bit manipulation
> more readable, and expand on some of the documentation.
>
> This patch incorporates content from Cyrill Gorcunov
> <gorcunov@xxxxxxxxx> as well.

I don't like it, I already explained why I don't consider the 'magic'
values a problem. The use of the bits is supposed to be scatterlist.h
private and the values are documented at the top of that include file.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/