Re: [PATCH 0/4] Unexport several headers and cleanup

[Kirill A. Shutemov]

On [Tue, 30.10.2007 08:47], David Woodhouse wrote:
> On Tue, 2007-10-30 at 13:02 +0200, Kirill A. Shutemov wrote:
> > This series of patches unexport several unneeded(I guess) headers from 
> > userspace. Patches based on patch posted to linux-kernel@ by Mike Frysinger
> > in July.
> 
> Looks OK to me, in general. How much userspace have you tested building
> with this? Does it include stuff like gdb?

I have rebuilt gdb-6.6 on x86_64. Ok.

Also, it fix building directfb on ARM. ;)
 
> Not that I necessarily care about the answer in the normal way -- it's
> just that if userspace will need to adapt, I'd like to get them moving
> ASAP. One option for easing that might be to export stuff like page.h
> but _empty_.

It's bad idea. Taken from directfb:

#if HAVE_ASM_PAGE_H
#include <asm/page.h>
#else
#define PAGE_SIZE   sysconf( _SC_PAGESIZE )
#endif

Other application can use something like this. I think we should drop
empty headers.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + Velesys LLC, http://www.velesys.com/
 + ALT Linux Team, http://www.altlinux.com/

Attachment: signature.asc
Description: Digital signature