Re: [PATCH 4/16] CRIS architecture: Correct compile errors

From: Andrew Morton
Date: Tue Oct 30 2007 - 18:14:35 EST


On Tue, 30 Oct 2007 10:30:00 +0100
Jesper Nilsson <jesper.nilsson@xxxxxxxx> wrote:

>
> Include asm/irq.h to avoid undefined value warning.
>

When fixing build errors or warnings please always always quote the
compiler output so that we can see what you're actually fixing. Saying
"undefined value warning" is pretty useless.

When quoting gcc output, please ensure that LANG=C was set - otherwise gcc
will emit utf gobbledigook which basically never makes it through the
system unscathed.

> diff -urBb -X /h/jespern/.exclude_files clean_linux-2.6.23/include/asm-cris/hardirq.h linux-2.6.23/include/asm-cris/hardirq.h
> --- clean_linux-2.6.23/include/asm-cris/hardirq.h 2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/include/asm-cris/hardirq.h 2007-10-22 10:35:12.000000000 +0200
> @@ -1,6 +1,7 @@
> #ifndef __ASM_HARDIRQ_H
> #define __ASM_HARDIRQ_H
>
> +#include <asm/irq.h>
> #include <linux/threads.h>
> #include <linux/cache.h>
>

hrm, OK. Not linux/irq.h? I guess not, as cris doesn't appear to support
CONFIG_GENERIC_HARDIRQS.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/