Re: tipc_config.h requires linux/string.h, which does not exist inexported headers

[David Miller]

From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Tue, 30 Oct 2007 23:20:25 +0100

> On Tue, Oct 30, 2007 at 03:05:37PM -0700, David Miller wrote:
> > From: David Miller <davem@xxxxxxxxxxxxx>
> > Date: Tue, 30 Oct 2007 14:59:26 -0700 (PDT)
> > 
> > > I think the thing to do is just __KERNEL__ protect the
> > > <linux/string.h> include and require userspace to
> > > include <string.h> itself when using these headers.
> > > 
> > > That's what I'm testing right now.
> > > 
> > > I'm pretty sure those inlines are indeed used by userspace.
> > 
> > Actually, I'm tempted to put <string.h> in the ifndef __KERNEL__
> > block of that header.
> 
> Something like this..
> I like it - much better than adding string.h to unidef-y.
> PS - had not pulled latest -linus - so you must update Kbuild.
> PPS - tipc.h should be exported too as I understood Stephen.

tipc.h is already listed in header-y.

I'll merge your patch, thanks Sam.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/