Re: [PATCH] dump_stack on panic

[Steven Rostedt]

--
On Wed, 31 Oct 2007, Arjan van de Ven wrote:

> On Tue, 30 Oct 2007 20:02:59 -0400
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > Is there any reason why we don't do a dump_stack on panic?
>
>
> panic() should never be used for kernel type of bugs, that's what
> BUG_ON() is for. panic() tends to be for "your cpu melted" and "you
> don't have a root fs".. nothing else.
>
> for both of those cases, a stack trace actually hurts because it
> scrolls the useful information off the screen instead.

Then we need to go and remove all the panics that are not needed and
replace them with Bugs.

I've had too many issues in development where I hit a panic and it gives
me nothing to tell me why.

At the very least, we should have a dump_stack in areas that are usually
caused by kernel bugs. For example, killing an interrupt handler.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/