RE: [PATCH resend] Make the dev_*() family of macros in device.hcomplete

[Medve Emilian-EMMEDVE1]

Hello Andrew,


Thanks for the detailed background.

By now I also submitted a patch with extra spaces. Which one would be a
better candidate for applying in a maintainer's tree (which tree?)?
Could you please pick up one of the versions? Should I resubmit the
first version without extra spaces?


Cheers,
Emil.


> -----Original Message-----
> From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] 
> Sent: Thursday, November 01, 2007 6:57 PM
> To: Greg KH
> Cc: Medve Emilian-EMMEDVE1; linux-kernel@xxxxxxxxxxxxxxx; 
> hjlipp@xxxxxx; tilman@xxxxxxx; 
> gigaset307x-common@xxxxxxxxxxxxxxxxxxxxx; kkeil@xxxxxxx; 
> isdn4linux@xxxxxxxxxxxxxxxxxxxxxx; mac@xxxxxxxxxx; 
> linux-omap-open-source@xxxxxxxxxxxxxx
> Subject: Re: [PATCH resend] Make the dev_*() family of macros 
> in device.hcomplete
> 
> On Tue, 30 Oct 2007 08:40:08 -0700
> Greg KH <gregkh@xxxxxxx> wrote:
> 
> > On Tue, Oct 30, 2007 at 05:11:24AM -0700, Medve 
> Emilian-EMMEDVE1 wrote:
> > > Hi Greg K-H,
> > > 
> > > 
> > > > > +#define dev_info(dev, format, arg...)		\
> > > > > +	dev_printk(KERN_INFO, dev, format, ## arg)
> > > > > +
> > > > >  #ifdef DEBUG
> > > > >  #define dev_dbg(dev, format, arg...)		\
> > > > > -	dev_printk(KERN_DEBUG , dev , format , ## arg)
> > > > > +	dev_printk(KERN_DEBUG, dev, format, ## arg)
> > > > 
> > > > Those extra spaces are there for a good reason, older 
> versions of gcc
> > > > are broken without it.  So please, put them all back...
> > > 
> > > You mean I should add spaces before commas only where they were
> > > initially or to all new code and/or macros?
> > 
> > Put it back where it was, and do the same for all other macros.
> > 
> > > I've observed other kernel code and more often there are no spaces
> > > before commas. I'm asking because the CodingStyle 
> document is not very
> > > explicit about this rule.
> > 
> > This is a gcc rule, for variable length macros, not a CodingStyle
> > guideline.  It just will not work without it :)
> > 
> 
> The space-before-a-comma requirement was for gcc-2.95, iirc.
> 
> It got to the stage where I was the only person testing with 
> gcc-2.95 so I
> spent inordinate amounts of time adding spaces before 
> people's newly-added
> commas.  Fortunately we abamdoned that gcc version so the 
> space-before-a-comma
> requirement no longer exists.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/