Re: [PATCH] Fix delay accounting regression

[Ingo Molnar]

* Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> On Fri, Nov 02, 2007 at 04:53:58PM +0100, Ingo Molnar wrote:
> > 
> > * Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > Fix the delay accounting regression introduced by commit 
> > > 75d4ef16a6aa84f708188bada182315f80aab6fa. rq no longer has sched_info 
> > > data associated with it. task_struct sched_info structure is used by 
> > > delay accounting to provide back statistics to user space.
> > 
> > no, this really is broken code. sched_clock() is not a generally 
> > reliable time source so at a minimum the rq->clock fix i mentioned is 
> > needed. What user-space tools are utilizing delay-accounting by the way? 
> > We have most of this data available under SCHEDSTATS - how about 
> > consolidating CONFIG_TASK_DELAY_ACCT into CONFIG_SCHEDSTATS?
> > 
> > 	Ingo
> 
> Hi, Ingo,
> 
> How about this?

thanks, applied.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/