Re: [PATCH] replace "make ARCH=i386/x86_64 with make ARCH=x86"

From: Adrian Bunk
Date: Mon Nov 05 2007 - 20:29:52 EST


On Mon, Nov 05, 2007 at 03:46:20PM -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
>> On Mon, Nov 05, 2007 at 01:36:42PM -0800, Roland Dreier wrote:
>>> > Like this:
>>> > $ make ARCH=foo
>>> > Makefile:201: *** "ERROR: ARCH (foo) does not exist". Stop.
>>>
>>> Seems sane, but maybe it would be worth putting in a special case
>>> check for someone using i386 or x86_64 for ARCH, and tell them to
>>> switch to x86?
>>
>> Will do so if my patchset gets applied. Need to redo it but
>> that will be later this week and then I hope for a bit more
>> feedback from the x86 guys.
>
> The patchset has looked good to me, and I believe it would be better to
> take this particular breakage sooner rather than later.
>
> I haven't spoken up actively mostly because I wanted to look at the user
> comments as they have been coming in.
>
> The issue with "make allyesconfig" concerns me, although the same situation
> already exists with any multiple-choice configuration. What I guess we
> really want is to be able to specify a few specific choices.

It's already available:

$ cat myconfig
CONFIG_HIGHMEM64G=y
CONFIG_SMP=n
CONFIG_PCI=n
CONFIG_IPV6=m
$ make allyesconfig KCONFIG_ALLCONFIG=myconfig

> -hpa

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/