Re: [PATCH 03/10] x86: arch/x86/Kconfig.cpu unification

[Sam Ravnborg]

On Mon, Nov 05, 2007 at 07:53:39PM -0500, Brian Gerst wrote:
> Sam Ravnborg wrote:
> > Move all CPU definitions to Kconfig.cpu
> 
> This patch causes build failure on x86_64:
> 
> lib/rwsem.c: In function â__init_rwsemâ:
> lib/rwsem.c:24: error: âstruct rw_semaphoreâ has no member named âcountâ
> lib/rwsem.c:24: error: âRWSEM_UNLOCKED_VALUEâ undeclared (first use in
> this function)
> lib/rwsem.c:24: error: (Each undeclared identifier is reported only once
> lib/rwsem.c:24: error: for each function it appears in.)
> lib/rwsem.c: In function â__rwsem_do_wakeâ:
> lib/rwsem.c:64: error: implicit declaration of function
> ârwsem_atomic_updateâ
> lib/rwsem.c:64: error: âRWSEM_ACTIVE_BIASâ undeclared (first use in this
> function)
> lib/rwsem.c:66: error: âRWSEM_ACTIVE_MASKâ undeclared (first use in this
> function)
> lib/rwsem.c:115: error: âRWSEM_WAITING_BIASâ undeclared (first use in
> this function)
> lib/rwsem.c:120: error: implicit declaration of function ârwsem_atomic_addâ
> lib/rwsem.c: In function ârwsem_down_failed_commonâ:
> lib/rwsem.c:169: error: âRWSEM_ACTIVE_MASKâ undeclared (first use in
> this function)
> lib/rwsem.c: In function ârwsem_down_read_failedâ:
> lib/rwsem.c:197: error: âRWSEM_WAITING_BIASâ undeclared (first use in
> this function)
> lib/rwsem.c:197: error: âRWSEM_ACTIVE_BIASâ undeclared (first use in
> this function)
> lib/rwsem.c: In function ârwsem_down_write_failedâ:
> lib/rwsem.c:210: error: âRWSEM_ACTIVE_BIASâ undeclared (first use in
> this function)
> 
> git bisect gives:
> 55432d383871d127685d78f94e0ad60307dcc0e9 is first bad commit
> commit 55432d383871d127685d78f94e0ad60307dcc0e9
> Author: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Date:   Thu Nov 1 21:54:39 2007 +0100
> 
>     x86: arch/x86/Kconfig.cpu unification

Seems that a default value fail to change value when we shift
from 32 to 64 bit. I have it reproduced here.
Will look at it tonight.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/