Re: + x86-show-cpuinfo-only-for-online-cpus.patch added to -mmtree

From: Andreas Herrmann
Date: Tue Nov 06 2007 - 14:21:37 EST


On Thu, Nov 01, 2007 at 03:31:23PM -0700, Yinghai Lu wrote:
>
> wonder if could change
>
> > if (!cpu_online(c->cpu_index))
> > return 0;
>
> ==>
>
> > if (c->cpu_index >= NR_CPUS)
> > return 0;
>
> and add another entry for every cpu
> online : 1 when it is enabled
> or online : 0 when it is disabled by /sys/devices/system/cpuX/online.

No, I don't think that would be a good idea. It would change
the usual behaviour of that interface (to display only CPUs that
are "up and running".)


Regards,

Andreas

--
Operating | AMD Saxony Limited Liability Company & Co. KG,
System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Research | Register Court Dresden: HRA 4896, General Partner authorized
Center | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
(OSRC) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/