Re: [PATCH] arch/x86/kernel/setup_64.c compile error(MMOTM-2007-11-10-19-05)

From: Andrew Morton
Date: Mon Nov 12 2007 - 20:48:41 EST


On Tue, 13 Nov 2007 02:32:29 +0100 Andi Kleen <ak@xxxxxxx> wrote:

>
> > hm, that doesn't seem right. We want to run the early quirks on non-ACPI
> > kernel too, surely?
>
> Most of early-quirks.c makes only sense with ACPI. The only exception would
> be the ATI timer override check, but frankly it's fairly unlikely that there
> are any ATI based boards around who still have mptables. Non ACPI
> tables would very likely just run in PIC mode and then need no timer overrides
> anyways.
>
> Originally on i386 the early quirks equivalent was 100% ACPI specific.
>

OK.... But what's The Right Thing To Do here? Would one be reasonable in
expecting that one can add a new early quirk which is independent from acpi
and have it still work on non-acpi builds?

Seems better to decouple the two things if poss?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/