[LOCK] Is it really necessary to use a "big module lock"?

[Jerry Jiang]

Hi all,

I came across a question when review other's module code.

something like:

int __init module_init()
{
	down_interruptible(the_big_module_sem);
	// code for init...
	up(the_big_module_sem);
}

void __exit module_exit()
{
	down_interruptible(the_big_module_sem);
	// code for exit...
	up(the_big_module_sem);
}

My question is:
 - Is the lock truly necessary?
 - If adding it into code, what happens?

Thank you
-- Jerry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/