Re: [RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() withget_online_cpus()

From: Ralf Baechle DL5RB
Date: Thu Nov 15 2007 - 10:38:34 EST


On Thu, Nov 15, 2007 at 07:22:02PM +0530, Gautham R Shenoy wrote:

> Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use
> get_online_cpus and put_online_cpus instead as it highlights
> the refcount semantics in these operations.
>
> The new API guarantees protection against the cpu-hotplug operation,
> but it doesn't guarantee serialized access to any of the local data
> structures. Hence the changes needs to be reviewed.
>
> In case of pseries_add_processor/pseries_remove_processor, use
> cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the
> cpu_present_map there.
>
> Signed-off-by: Gautham R Shenoy <ego@xxxxxxxxxx>
> ---
> Documentation/cpu-hotplug.txt | 11 ++++++-----
> arch/mips/kernel/mips-mt-fpaff.c | 10 +++++-----

Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

for the MIPS part.

Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/