Re: [PATCH 2/2] sched: Improve fairness of cpu allocation for taskgroups

From: Ingo Molnar
Date: Mon Nov 19 2007 - 08:12:22 EST



* Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx> wrote:

> The current load balancing scheme isn't good for group fairness.

> ---
> include/linux/sched.h | 4
> kernel/sched.c | 292 +++++++++++++++++++++++++++++++++++++++++++++-----
> kernel/sched_fair.c | 95 ++++++++++------
> kernel/sched_rt.c | 2
> kernel/sysctl.c | 16 ++
> 5 files changed, 348 insertions(+), 61 deletions(-)

i'm leaning towards making this v2.6.25 material, as it affects the
non-group-scheduling bits too and is rather large. When i tested it,
group scheduling worked pretty well - at least for CPU bound tasks - and
on SMP too. Could we live with what we have for now and defer this patch
to v2.6.25? If not, could you split up this patch in a way to defer all
the FAIR_GROUP_SCHED relevant changes to a separate patch which will not
affect the !FAIR_GROUP_SCHED case at all? That will make the case much
clearer.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/