Re: [patch 19/26] USB: mutual exclusion for EHCI init and portresets

From: Greg KH
Date: Mon Nov 19 2007 - 18:00:59 EST


On Mon, Nov 19, 2007 at 02:32:41PM -0800, David Miller wrote:
> From: David Brownell <david-b@xxxxxxxxxxx>
> Date: Mon, 19 Nov 2007 11:59:55 -0800
>
> > > This addition certainly won't hurt. Did we ever get any feedback as to
> > > whether it actually helped?
> >
> > ISTR that davem refused to try it, after reporting an
> > intermittent failure on the original patch (which only
> > addresses one end of that hardware race).
> >
> > So, no ... but given we know that closing only one side
> > of the race isn't quite enough, I think we need it anyway.
>
> I think we should put all these changes in because at a minimum
> it's a step in the right direction even if it doesn't close
> the hole %100.
>
> So please let's merge the mutex and the msleep() change in
> ASAP, thanks.

The msleep one is queued up for the next Linus pull, and after it goes
in, I'll add it to the -stable trees as well.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/