Re: [PATCH 01/59] arch/ia64: Add missing "space"

From: Simon Horman
Date: Tue Nov 20 2007 - 02:41:46 EST


On Mon, Nov 19, 2007 at 11:09:25PM -0800, Joe Perches wrote:
> On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote:
> > Is it really neccessary for this fragment to create a line that
> > is greater than 80 characters long? Persumably the entire reason
> > that the printk line was split in the first place was to avoid
> > a long line.
>
> No. Many other lines in that source file are > 80 char.

That may be so, but surely adding another one makes
things slightly worse.

> My initial preference was to reformat the indented lines to the
> printk open parenthesis, but the minimal change seemed better.
>
> cheers, Joe

--
Horms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/