Re: [patch][v2] x86, ptrace: support for branch trace store(BTS)

[dean gaudet]

On Tue, 20 Nov 2007, dean gaudet wrote:

> On Tue, 20 Nov 2007, Metzger, Markus T wrote:
> 
> > +__cpuinit void ptrace_bts_init_intel(struct cpuinfo_x86 *c)
> > +{
> > +	switch (c->x86) {
> > +	case 0x6:
> > +		switch (c->x86_model) {
> > +#ifdef __i386__
> > +		case 0xD:
> > +		case 0xE: /* Pentium M */
> > +			ptrace_bts_ops = ptrace_bts_ops_pentium_m;
> > +			break;
> > +#endif /* _i386_ */
> > +		case 0xF: /* Core2 */
> > +			ptrace_bts_ops = ptrace_bts_ops_core2;
> > +			break;
> > +		default:
> > +			/* sorry, don't know about them */
> > +			break;
> > +		}
> > +		break;
> > +	case 0xF:
> > +		switch (c->x86_model) {
> > +#ifdef __i386__
> > +		case 0x0:
> > +		case 0x1:
> > +		case 0x2:
> > +		case 0x3: /* Netburst */
> > +			ptrace_bts_ops = ptrace_bts_ops_netburst;
> > +			break;
> > +#endif /* _i386_ */
> > +		default:
> > +			/* sorry, don't know about them */
> > +			break;
> > +		}
> > +		break;
> 
> is this right?  i thought intel family 15 models 3 and 4 supported amd64
> mode...

actually... why aren't you using cpuid level 1 edx bit 21 to 
enable/disable this feature?  isn't that the bit defined to indicate 
whether this feature is supported or not?

and it seems like this patch and perfmon2 are going to have to live with 
each other... since they both require the use of the DS save area...

-dean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/