Re: [PATCH 1/2] Don't forget to unlock uids_mutex on error paths

From: Ingo Molnar
Date: Fri Nov 23 2007 - 08:53:02 EST



* Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Nov 21, 2007 at 01:49:33PM +0300, Pavel Emelyanov wrote:
> > The commit
> >
> > commit 5cb350baf580017da38199625b7365b1763d7180
> > Author: Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx>
> > Date: Mon Oct 15 17:00:14 2007 +0200
> >
> > sched: group scheduling, sysfs tunables
> >
> > introduced the uids_mutex and the helpers to lock/unlock it.
> > Unfortunately, the error paths of alloc_uid() were not patched
> > to unlock it.

oops!

> Thanks for catching it. Looks good to me. Ingo, could you please pick
> these up?

yep - added.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/