Re: [PATCH 2/2] iwlwifi: add power management support -v2

From: Miguel Botón
Date: Mon Nov 26 2007 - 11:18:34 EST


On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote:
> Why power management shouldn't be enabled while in AC? The semantic of this
> ioctls is quite unclear.

IWL_POWER_AC and IWL_POWER_BATTERY are just two power modes. IWL_POWER_AC
would be the default power mode when we're in AC (no power saving) and
IWL_POWER_BATTERY would be the default power mode when we're in battery
(power saving mode). That's why we set IWL_POWER_ENABLED flag with
IWL_POWER_BATTERY, because it is the only power mode that saves power.

We can change to IWL_POWER_BATTERY or IWL_POWER_AC in any moment.

This patch, depending if power management is enabled or not, sets which power
mode we should use, Then, it checks if we're already using this mode or not.

--
Miguel Botón
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/