Re: [PATCH 3/4] drivers/usb: Drop unnecessary continue

From: Greg KH
Date: Tue Nov 27 2007 - 11:10:38 EST


On Wed, Nov 14, 2007 at 09:15:16AM +0100, Julia Lawall wrote:
> diff -u -p -b -B a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
> --- a/drivers/usb/host/isp116x-hcd.c 2007-10-22 11:25:24.000000000 +0200
> +++ b/drivers/usb/host/isp116x-hcd.c 2007-11-13 23:14:10.000000000 +0100
> @@ -918,7 +918,6 @@ static int isp116x_hub_status_data(struc
> | RH_PS_OCIC | RH_PS_PRSC)) {
> changed = 1;
> buf[0] |= 1 << (i + 1);
> - continue;
> }
> }
> spin_unlock_irqrestore(&isp116x->lock, flags);

Your email client is eating all the tabs and converting them to spaces,
making these patches very hard to apply.

I've fixed this one up by hand, but please, fix your email client for
future ones.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/