Re: [s390] networking related oops during boot on Hercules (was: build failure)

From: Frans Pop
Date: Wed Nov 28 2007 - 12:05:49 EST


On Wednesday 28 November 2007, Christian Borntraeger wrote:
> This seems to be related to the new network namespace code by Eric
> Biederman (CCed). Can you try the following (untested) patch? I also
> CCed Ursula and Peter as they know the ctc code better than me.

Yes, that fixes it. Boots fine now and I can ssh into the system. Not tested
any further than that.

Thanks Christian.

> CC: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> CC: Ursula Braun <braunu@xxxxxxxxxx>
> CC: Peter Tiedemann <ptiedem@xxxxxxxxxx>
> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>
> ---
> drivers/s390/net/ctcmain.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/s390/net/ctcmain.c
> ===================================================================
> --- linux-2.6.orig/drivers/s390/net/ctcmain.c
> +++ linux-2.6/drivers/s390/net/ctcmain.c
> @@ -56,6 +56,7 @@
> #include <linux/skbuff.h>
> #include <linux/ctype.h>
> #include <net/dst.h>
> +#include <net/net_namespace.h>
>
> #include <asm/io.h>
> #include <asm/ccwdev.h>
> @@ -2823,6 +2824,7 @@ ctc_init_netdevice(struct net_device * d
> dev->type = ARPHRD_SLIP;
> dev->tx_queue_len = 100;
> dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> + dev->nd_net = &init_net;
> return dev;
> }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/